Fix use of floating number for the timeout and forceKillAfterTimeout options

[Kikobeats]

When the timeout or forceKillAfterTimeout a float number is causes an error that can be avoided

[Kikobeats]

Ok I can see it's an intentional behavior

   64:   test('`forceKillAfterTimeout` should not be a float', t => {    

not sure why 🤔

[sindresorhus]

I don't remember. Maybe try Git blame.

[Kikobeats]

the code was refactored several times but isInteger was introduced here:
0bd5596#diff-168726dbe96b3ce427e7fedce31bb0bcR246

I couldn't determinate if number over float is necessary for a thing, maybe @ehmicky can know 🙂

[ehmicky]

Yes, I think we should allow floats.
However we should still disalllow NaN and Infinity, so Number.isFinite() might be better than typeof value === 'number' I believe?

[sindresorhus]

Yes, let’s do that.

[ehmicky]

The CI test are failing due to the following test:

execa/test/kill.js

Line 64 in a827d82

test('`forceKillAfterTimeout` should not be a float', t => {

This probably should be changed to check for NaN instead?

[Kikobeats]

@ehmicky test updated; still, some tests are failing but for a different reason no related with this PR

[ehmicky]

Thanks @Kikobeats,

It looks like you accidentally also removed the test that checks that the argument is not negative. Could you please add it back? Thanks :)

[Kikobeats]

@ehmicky ops, done!

[ehmicky]

Looks good, thanks!