Add error.originalMessage property
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Oct 8, 2019
|
Fixed :) |
sindresorhus
changed the title
error.originalMessageerror.originalMessage property
ehmicky
added a commit
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
errorevent is thrown on the child process or when a timeout happens, we re-use the originalErrorinstance instead of creating a new one. However we override theerror.message.This PR keep the original
error.messageas an additional propertyerror.originalMessage.I need this for one my projects using Execa. That project should proxy a user's command in such a way that users should not be aware of that proxy. In particular, the error messages produced by Execa should be not printed to the console. However the error messages coming from
errorevents on the child process (such ascommand not found) should be printed. This PR allows for this to happen.