Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cleanup option (code quality, tests, documentation) #225

Merged
merged 7 commits into from
May 8, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 7, 2019

This improves the cleanup option, but does not change its behavior:

  • small code simplification
  • added tests for options.detached: true (before only options.detached: false was tested)
  • fix tests not properly cleaning up created processes (i.e. memory leak)
  • improve option description on README

@ehmicky ehmicky requested a review from sindresorhus May 7, 2019 20:09
@ehmicky ehmicky changed the title Feature/improve cleanup Improve cleanup option (code quality, tests, documentation) May 7, 2019
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@ehmicky
Copy link
Collaborator Author

ehmicky commented May 8, 2019

Fixed.

I've also added some tests when the child process exists before the parent process, with the cleanup and detached options. This was not tested before.

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@ehmicky ehmicky force-pushed the feature/improve-cleanup branch from 63dc820 to 5974c2d Compare May 8, 2019 10:15
@ehmicky
Copy link
Collaborator Author

ehmicky commented May 8, 2019

Fixed

@sindresorhus sindresorhus merged commit 659f444 into master May 8, 2019
@sindresorhus sindresorhus deleted the feature/improve-cleanup branch May 8, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants