-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cleanup
option (code quality, tests, documentation)
#225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
changed the title
Feature/improve cleanup
Improve May 7, 2019
cleanup
option (code quality, tests, documentation)
sindresorhus
reviewed
May 8, 2019
sindresorhus
reviewed
May 8, 2019
Fixed. I've also added some tests when the child process exists before the parent process, with the |
sindresorhus
reviewed
May 8, 2019
sindresorhus
reviewed
May 8, 2019
ehmicky
force-pushed
the
feature/improve-cleanup
branch
from
May 8, 2019 10:15
63dc820
to
5974c2d
Compare
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the
cleanup
option, but does not change its behavior:options.detached: true
(before onlyoptions.detached: false
was tested)README