Update dependencies, refactor TypeScript definition to CommonJS compatible export #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, great! The dependencies update looks good to me 👍 . I cannot judge for TypeScript. Also there is one test that fails on CI. |
It's not new. I have to rerun the build one in a while. Seems the test is flaky on Node.js 8 on Windows. We should look into making it not flaky. |
|
Yes I noticed it as well before and was re-running the test on CI. However now I tried re-running several times and it kept failing. But it might just be luck. We should definitely look into that one test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sindresorhus This should be part of v2 milestone.
See this issue for details.