-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the spawned process cancelable #189
Merged
sindresorhus
merged 19 commits into
sindresorhus:master
from
ammarbinfaisal1:make-cancelable
Mar 19, 2019
Merged
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3b247c5
make cp cancelable (fixes #113)
ammarbinfaisal1 5a74c26
add a test for cancelable spawned processes
ammarbinfaisal1 88beb24
update docs
ammarbinfaisal1 7c743e0
correct usage of p-cancelable
ammarbinfaisal1 71b6abf
provide a default cancelation reason
ammarbinfaisal1 cef4609
fix coding style
ammarbinfaisal1 6c1e31c
add tests fro making spawned process cancelable
ammarbinfaisal1 7786ebd
remove useless ava assertions
ammarbinfaisal1 bef739a
don't use p-cancelable
ammarbinfaisal1 a24a895
remove p-cancelable from package.json
ammarbinfaisal1 629ba5f
make calling cancel method throw its own error
ammarbinfaisal1 9cd06d4
Merge branch 'master' into make-cancelable
ammarbinfaisal 282124c
add more tests
ammarbinfaisal1 2c70e6c
turn cancel true only when process is actually killed
ammarbinfaisal1 3cb85f1
update README
ammarbinfaisal1 089c7b0
update README
ammarbinfaisal1 d85eb02
rename canceled to isCanceled
ammarbinfaisal1 8cd3fcf
update docs
ammarbinfaisal1 f5c35c9
Update index.js
sindresorhus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -143,7 +143,7 @@ function getStream(process, stream, {encoding, buffer, maxBuffer}) { | |
function makeError(result, options) { | ||
const {stdout, stderr, code, signal} = result; | ||
let {error} = result; | ||
const {joinedCommand, timedOut, parsed: {options: {timeout}}} = options; | ||
const {joinedCommand, timedOut, canceled, parsed: {options: {timeout}}} = options; | ||
|
||
const [exitCodeName, exitCode] = getCode(result, code); | ||
|
||
|
@@ -152,7 +152,7 @@ function makeError(result, options) { | |
error = new Error(message); | ||
} | ||
|
||
const prefix = getErrorPrefix({timedOut, timeout, signal, exitCodeName, exitCode}); | ||
const prefix = getErrorPrefix({timedOut, timeout, signal, exitCode, exitCodeName, canceled}); | ||
error.message = `Command ${prefix}: ${error.message}`; | ||
|
||
error.code = exitCode || exitCodeName; | ||
|
@@ -164,6 +164,7 @@ function makeError(result, options) { | |
error.signal = signal || null; | ||
error.cmd = joinedCommand; | ||
error.timedOut = Boolean(timedOut); | ||
error.canceled = canceled; | ||
|
||
if ('all' in result) { | ||
error.all = result.all; | ||
|
@@ -184,11 +185,15 @@ function getCode({error = {}}, code) { | |
return []; | ||
} | ||
|
||
function getErrorPrefix({timedOut, timeout, signal, exitCodeName, exitCode}) { | ||
function getErrorPrefix({timedOut, timeout, signal, exitCodeName, exitCode, canceled}) { | ||
if (timedOut) { | ||
return `timed out after ${timeout} milliseconds`; | ||
} | ||
|
||
if (canceled) { | ||
return 'was canceled'; | ||
} | ||
|
||
if (signal) { | ||
return `was killed with ${signal}`; | ||
} | ||
|
@@ -239,6 +244,7 @@ module.exports = (command, args, options) => { | |
|
||
let timeoutId = null; | ||
let timedOut = false; | ||
let canceled = false; | ||
|
||
const cleanup = () => { | ||
if (timeoutId) { | ||
|
@@ -304,11 +310,12 @@ module.exports = (command, args, options) => { | |
result.stderr = results[2]; | ||
result.all = results[3]; | ||
|
||
if (result.error || result.code !== 0 || result.signal !== null) { | ||
if (result.error || result.code !== 0 || result.signal !== null || canceled) { | ||
const error = makeError(result, { | ||
joinedCommand, | ||
parsed, | ||
timedOut | ||
timedOut, | ||
canceled | ||
}); | ||
|
||
// TODO: missing some timeout logic for killed | ||
|
@@ -334,7 +341,8 @@ module.exports = (command, args, options) => { | |
killed: false, | ||
signal: null, | ||
cmd: joinedCommand, | ||
timedOut: false | ||
timedOut: false, | ||
canceled: false | ||
}; | ||
}), destroy); | ||
|
||
|
@@ -347,6 +355,12 @@ module.exports = (command, args, options) => { | |
// eslint-disable-next-line promise/prefer-await-to-then | ||
spawned.then = (onFulfilled, onRejected) => handlePromise().then(onFulfilled, onRejected); | ||
spawned.catch = onRejected => handlePromise().catch(onRejected); | ||
spawned.cancel = function () { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use arrow function |
||
if (!spawned.killed) { | ||
ehmicky marked this conversation as resolved.
Show resolved
Hide resolved
|
||
canceled = true; | ||
spawned.kill(); | ||
} | ||
ammarbinfaisal1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}; | ||
|
||
// TOOD: Remove the `if`-guard when targeting Node.js 10 | ||
if (Promise.prototype.finally) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -586,3 +586,42 @@ if (Promise.prototype.finally) { | |||||
t.is(result.message, 'called'); | ||||||
}); | ||||||
} | ||||||
|
||||||
test('cancel method kills the spawned process', t => { | ||||||
const spawned = execa('node'); | ||||||
spawned.cancel(); | ||||||
t.true(spawned.killed); | ||||||
ehmicky marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
}); | ||||||
|
||||||
test('result.canceled is false when spawned.cancel isn\'t called', async t => { | ||||||
const spawned = execa('noop'); | ||||||
const result = await spawned; | ||||||
ehmicky marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
t.false(result.canceled); | ||||||
}); | ||||||
|
||||||
test('calling cancel method throws an error with message "Command was canceled"', async t => { | ||||||
const spawned = execa('noop'); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
spawned.cancel(); | ||||||
const error = await t.throwsAsync(async () => { | ||||||
await spawned; | ||||||
}); | ||||||
t.regex(error.message, /Command\swas\scanceled/); | ||||||
ehmicky marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
}); | ||||||
ehmicky marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
||||||
test('error.canceled is true when cancel method is used', async t => { | ||||||
const spawned = execa('noop'); | ||||||
spawned.cancel(); | ||||||
const error = await t.throwsAsync(async () => { | ||||||
await spawned; | ||||||
}); | ||||||
ehmicky marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
t.true(error.canceled); | ||||||
}); | ||||||
|
||||||
test('error.canceled is false when kill method is used', async t => { | ||||||
ehmicky marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
const spawned = execa('noop'); | ||||||
spawned.kill(); | ||||||
const error = await t.throwsAsync(async () => { | ||||||
await spawned; | ||||||
}); | ||||||
t.false(error.canceled); | ||||||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to name it
isCanceled
. I realize it's inconsistent withkilled
, but I want to rename that one at some point too. Use theisCanceled
naming for all thecanceled
variables.