-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Node.js without ICU support #1144
Conversation
} | ||
|
||
static isMocked = true; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find a simple way to run tests using Node without ICU support. So this mimics it for our purpose.
}; | ||
|
||
// Execa computes the RegExp when first loaded, so we must delay this import | ||
await import('./escape.js'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could mock/unmock RegExp
directly in escape.js
, and run each test twice. But then each test would need to be serial. Also it makes the test file a little complex (this was my first approach). Using a separate test file that imports the other one results in less code.
When will it be released? :) |
This has now been released in Is this working? |
Thank you. Yes :). Great Success. |
Thanks for the shout out @Uzlopak, that's very kind! 🙏 |
Unfortunately, you are not on twitter, or else I would have linked you. |
Fixes #1143.
This PR does not add any documentation because this is a very tiny edge case that almost nobody will encounter:
result.escapedCommand
) instead of being represented as a backslash sequence\u...
, which is not a big problem.