-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .fork()
method
#65
Comments
That is, as always with Stack Overflow answers, incorrect. We should definitely add Pull request welcome :) |
If anyone wants to take on this, see #108 for context and previous work. |
@IssueHunt has funded $60.00 to this issue.
|
Just to add to the discussion, I don't think there is any "added optimization" with
So there are no optimizations. However this is convenient for two reasons:
|
@ehmicky Yes, it's mostly for convenience, but also:
|
Oh yes you're right. This could be seen as a convenience as well since this can be achieved with Also to my above points, we should add that |
@GMartigny @ehmicky I think you missed this. |
I agree that I think we should either:
Some things where we might consider deviating: What do you think? |
I think we should yes. Not sure which I like the most of
I agree. We don't need it. It should just default to
I doubt it has any real performance impact. |
Alright, so the consequences would be:
@GMartigny what do you think? |
Either We can (and certainly should) keep |
No, it's meant to be able to specify which Node.js executable you want. I already commented about clarifying the option description in your PR. |
@sindresorhus has rewarded $54.00 to @GMartigny. See it on IssueHunt
|
We could just use
execa('node', ['becomeTheOne.js'])
, but that would mean not capitalising on the added optimization that happens when using fork, as mentioned here.IssueHunt Summary
[
<
i
m
g
s
r
c
'
h
t
t
p
s
:
/
/
a
v
a
t
a
r
s
3
.
g
i
t
h
u
b
u
s
e
r
c
o
n
t
e
n
t
.
c
o
m
/
u
/
2
5
4
3
5
1
1
?
v
4
'
a
l
t
'
g
m
a
r
t
i
g
n
y
'
w
i
d
t
h
2
4
h
e
i
g
h
t
2
4
g
m
a
r
t
i
g
n
y
]
(
h
t
t
p
s
:
/
/
i
s
s
u
e
h
u
n
t
.
i
o
/
u
/
g
m
a
r
t
i
g
n
y
)
h
a
s
b
e
e
n
r
e
w
a
r
d
e
d
.
Backers (Total: $60.00)
Submitted pull Requests
Tips
IssueHunt has been backed by the following sponsors. Become a sponsor
The text was updated successfully, but these errors were encountered: