Update snapshots #2485
Merged
Update snapshots #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Oct 20, 2024
package.json
Outdated
| @@ -22,6 +22,7 @@ | |||
| "fix": "run-p --continue-on-error fix:*", | |||
| "fix:eslint-docs": "eslint-doc-generator", | |||
| "fix:js": "npm run lint:js -- --fix", | |||
| "fix:snapshots": "ava --update-snapshots", | |||
There was a problem hiding this comment.
I'm also including the snapshots in the fix command, which I thought was enough initially but it did not update the snapshots
|
@fisker vscode's integration test has been failing for a few days, but the affected haven't changed in years. |
fisker
approved these changes
Oct 20, 2024
I'm not sure how the parser changed, but the typescript parser is super forgiving, it allow many kind of invalid syntax, it's been problem for years in Prettier to handle all unexpected AST, until last year they starts to add extra checks for invalid syntaxes. My PRs |
|
Ah, I believe the parser correctly treat it as module now, it enbles strict mode, which also request by me.. typescript-eslint/typescript-eslint#9101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following fe4e7bc