Switch create-rule and integration test to module (#1205)

sindresorhus · Apr 23, 2021 · f1f30c3 · f1f30c3
1 parent 5a4dc90
commit f1f30c3
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 33 deletions.
diff --git a/package.json b/package.json
@@ -15,9 +15,9 @@
 	},
 	"scripts": {
 		"test": "xo && nyc ava",
-		"create-rule": "node ./scripts/create-rule.js && npm run generate-rules-table",
+		"create-rule": "node ./scripts/create-rule.mjs && npm run generate-rules-table",
 		"run-rules-on-codebase": "node ./test/run-rules-on-codebase/lint.mjs",
-		"integration": "node ./test/integration/test.js",
+		"integration": "node ./test/integration/test.mjs",
 		"smoke": "eslint-remote-tester --config ./test/smoke/eslint-remote-tester.config.js",
 		"generate-rules-table": "node ./scripts/generate-rules-table.mjs"
 	},

diff --git a/scripts/create-rule.js → scripts/create-rule.mjs b/scripts/create-rule.js → scripts/create-rule.mjs
@@ -1,13 +1,13 @@
 #!/usr/bin/env node
-'use strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import {fileURLToPath} from 'node:url';
+import enquirer from 'enquirer';
+import {template} from 'lodash-es';
+import execa from 'execa';
 
-const fs = require('fs');
-const path = require('path');
-const enquirer = require('enquirer');
-const {template} = require('lodash');
-const execa = require('execa');
-
-const ROOT = path.join(__dirname, '..');
+const dirname = path.dirname(fileURLToPath(import.meta.url));
+const ROOT = path.join(dirname, '..');
 
 function checkFiles(ruleId) {
 	const files = [
@@ -24,7 +24,7 @@ function checkFiles(ruleId) {
 }
 
 function renderTemplate({source, target, data}) {
-	const templateFile = path.join(__dirname, `template/${source}`);
+	const templateFile = path.join(dirname, `template/${source}`);
 	const targetFile = path.join(ROOT, target);
 	const templateContent = fs.readFileSync(templateFile, 'utf8');
 

diff --git a/test/integration/projects.js → test/integration/projects.mjs b/test/integration/projects.js → test/integration/projects.mjs
@@ -1,10 +1,12 @@
-'use strict';
-const path = require('path');
+import path from 'node:path';
+import {fileURLToPath} from 'node:url';
 
-module.exports = [
+const dirname = path.dirname(fileURLToPath(import.meta.url));
+
+export default [
 	{
 		name: 'fixtures-local',
-		location: path.join(__dirname, 'fixtures-local')
+		location: path.join(dirname, 'fixtures-local')
 	},
 	{
 		repository: 'https://github.com/avajs/ava',

diff --git a/test/integration/test.js → test/integration/test.mjs b/test/integration/test.js → test/integration/test.mjs
@@ -1,14 +1,15 @@
 #!/usr/bin/env node
-'use strict';
-const fs = require('fs');
-const path = require('path');
-const Listr = require('listr');
-const execa = require('execa');
-const chalk = require('chalk');
-const {isCI} = require('ci-info');
-const mem = require('mem');
-const allProjects = require('./projects');
-
+import fs from 'node:fs';
+import path from 'node:path';
+import {fileURLToPath} from 'node:url';
+import Listr from 'listr';
+import execa from 'execa';
+import chalk from 'chalk';
+import {isCI} from 'ci-info';
+import mem from 'mem';
+import allProjects from './projects.mjs';
+
+const dirname = path.dirname(fileURLToPath(import.meta.url));
 const projectsArguments = process.argv.slice(2);
 const projects = projectsArguments.length === 0 ?
 	allProjects :
@@ -35,7 +36,7 @@ const makeEslintTask = (project, destination) => {
 		'--format',
 		'json',
 		'--config',
-		path.join(__dirname, 'config.js')
+		path.join(dirname, 'config.js')
 	];
 
 	for (const pattern of project.ignore) {
@@ -46,7 +47,7 @@ const makeEslintTask = (project, destination) => {
 		let stdout;
 		let processError;
 		try {
-			({stdout} = await execa('npx', arguments_, {cwd: destination, localDir: __dirname}));
+			({stdout} = await execa('npx', arguments_, {cwd: destination, localDir: dirname}));
 		} catch (error) {
 			({stdout} = error);
 			processError = error;
@@ -89,7 +90,7 @@ const makeEslintTask = (project, destination) => {
 const getBranch = mem(async dirname => (await execa('git', ['branch', '--show-current'], {cwd: dirname})).stdout);
 
 const execute = project => {
-	const destination = project.location || path.join(__dirname, 'fixtures', project.name);
+	const destination = project.location || path.join(dirname, 'fixtures', project.name);
 
 	return new Listr([
 		{
@@ -120,7 +121,7 @@ const execute = project => {
 const list = new Listr([
 	{
 		title: 'Setup',
-		task: () => execa('npm', ['install'], {cwd: __dirname})
+		task: () => execa('npm', ['install'], {cwd: dirname})
 	},
 	{
 		title: 'Integration tests',

diff --git a/test/run-rules-on-codebase/lint.mjs b/test/run-rules-on-codebase/lint.mjs
@@ -38,11 +38,9 @@ const eslint = new ESLint({
 					// ESLint don't support module
 					'rules/**/*.js',
 					'index.js',
+					'test/integration/config.js',
 					// `eslint-remote-tester` only support cjs config
-					'test/smoke/eslint-remote-tester.config.js',
-					// TODO: Switch to module
-					'scripts/create-rule.js',
-					'test/integration/**/*'
+					'test/smoke/eslint-remote-tester.config.js'
 				],
 				rules: {
 					'unicorn/prefer-module': 'off'