Allow async listeners in the TypeScript types #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airhorns
force-pushed
the
async-listener-types
branch
from
89513a7
to
dec7b6c
Compare
airhorns
force-pushed
the
async-listener-types
branch
from
dec7b6c
to
f9cca0f
Compare
|
Can you fix the merge conflict? |
Emittery already supports awaiting event emission, which in turn awaits all the listeners that return a Promise. If a caller awaits `emit`, all the listeners will have resolved by the time the outer promise resolves, which is great! This adds a test for that behaviour, and updates the TypeScript types to support these async listeners. There's no new or changed behaviour.
airhorns
force-pushed
the
async-listener-types
branch
from
f9cca0f
to
2d4a6a8
Compare
Co-authored-by: Sindre Sorhus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #69.
Emittery already supports awaiting event emission, which in turn awaits all the listeners that return a Promise. If a caller awaits
emit, all the listeners will have resolved by the time the outer promise resolves, which is great!This adds a test for that behaviour, and updates the TypeScript types to support these async listeners. There's no new or changed behaviour.