Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Relative Directory Loading Failure #45

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Fix Relative Directory Loading Failure #45

merged 3 commits into from
Sep 17, 2024

Conversation

itsonlyjames
Copy link
Contributor

Solves #44.

All credit goes to @k7sleeper.

@itsonlyjames itsonlyjames mentioned this pull request Sep 12, 2024
Closed
@sindresorhus
Copy link
Owner

This is not correct. relativePath can never be null.

@itsonlyjames
Copy link
Contributor Author

Simplified 👍

@Muhammed-Rahif
Copy link

Muhammed-Rahif commented Sep 16, 2024 •
edited
Loading

FYI: This works fine and resolves the Error: ERR_FILE_NOT_FOUND (-6) loading 'app://-/'. Potentially resolve #29

@sindresorhus sindresorhus merged commit 633af66 into sindresorhus:main Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsonlyjames @sindresorhus @Muhammed-Rahif