Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This module may break soon #2

Closed
zeke opened this issue Jul 28, 2016 · 2 comments
Closed

This module may break soon #2

zeke opened this issue Jul 28, 2016 · 2 comments

Comments

@zeke
Copy link
Contributor

zeke commented Jul 28, 2016

A kind soul (@logicalparadox) has allowed us to take over the electron package name on npm, and we are beginning the process of publishing electron-prebuilt and electron in tandem for a while.

If a user installs the new electron, this package in its current form will not be able to detect that, because it's looking for -prebuilt in the path name:

module.exports = process.defaultApp || /[\\/]electron-prebuilt[\\/]/.test(process.execPath);

Context: electron-userland/electron-prebuilt#160

@parro-it
Copy link

Thank you for the notice @zeke. We was planning to change the check and use an env variable.
We are discussing it here and here

I did a PR on electron-prebuilt to make it set such variable, so that we can check it.

This should solve the name change problem.

@zeke
Copy link
Contributor Author

zeke commented Jul 29, 2016

cc @kevinsawicki who suggested there might be a baked-in way to do this already.

zeke added a commit to zeke/electron-is-dev that referenced this issue Aug 15, 2016
From http://electron.atom.io/docs/api/process/#processdefaultapp

> When app is started by being passed as parameter to the default app, this property is `true` in the main process, otherwise it is `undefined`.

Fixes sindresorhus#2
sindresorhus pushed a commit that referenced this issue Aug 17, 2016
From http://electron.atom.io/docs/api/process/#processdefaultapp

> When app is started by being passed as parameter to the default app, this property is `true` in the main process, otherwise it is `undefined`.

Fixes #2
sindresorhus pushed a commit that referenced this issue Aug 17, 2016
From http://electron.atom.io/docs/api/process/#processdefaultapp

> When app is started by being passed as parameter to the default app, this property is `true` in the main process, otherwise it is `undefined`.

Fixes #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants