-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This module may break soon #2
Comments
Thank you for the notice @zeke. We was planning to change the check and use an env variable. I did a PR on electron-prebuilt to make it set such variable, so that we can check it. This should solve the name change problem. |
cc @kevinsawicki who suggested there might be a baked-in way to do this already. |
zeke
added a commit
to zeke/electron-is-dev
that referenced
this issue
Aug 15, 2016
From http://electron.atom.io/docs/api/process/#processdefaultapp > When app is started by being passed as parameter to the default app, this property is `true` in the main process, otherwise it is `undefined`. Fixes sindresorhus#2
sindresorhus
pushed a commit
that referenced
this issue
Aug 17, 2016
From http://electron.atom.io/docs/api/process/#processdefaultapp > When app is started by being passed as parameter to the default app, this property is `true` in the main process, otherwise it is `undefined`. Fixes #2
sindresorhus
pushed a commit
that referenced
this issue
Aug 17, 2016
From http://electron.atom.io/docs/api/process/#processdefaultapp > When app is started by being passed as parameter to the default app, this property is `true` in the main process, otherwise it is `undefined`. Fixes #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A kind soul (@logicalparadox) has allowed us to take over the
electron
package name on npm, and we are beginning the process of publishingelectron-prebuilt
andelectron
in tandem for a while.If a user installs the new
electron
, this package in its current form will not be able to detect that, because it's looking for-prebuilt
in the path name:Context: electron-userland/electron-prebuilt#160
The text was updated successfully, but these errors were encountered: