-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript definition #68
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7bf7895
Add TypeScript definition
CvX 567b82d
Make Options readonly
CvX 1ae1b7f
Import BrowserWindow from electron
CvX 03c8820
Use default parameters
CvX 666ed5a
Update index.d.ts
sindresorhus eba5313
Remove unused param docs
CvX 5a31702
Make props readonly
CvX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import { BrowserWindow } from "electron"; | ||
|
||
export interface Options { | ||
/** | ||
* Default: [Only in development](https://github.com/sindresorhus/electron-is-dev) | ||
*/ | ||
enabled?: boolean; | ||
|
||
/** | ||
* Show DevTools on each created `BrowserWindow`. | ||
* | ||
* @default true | ||
*/ | ||
showDevTools?: boolean; | ||
|
||
/** | ||
* The dock state to open DevTools in. | ||
* | ||
* @default 'undocked' | ||
*/ | ||
devToolsMode?: 'undocked' | 'right' | 'bottom' | 'previous' | 'detach'; | ||
} | ||
|
||
/** | ||
* Install keyboard shortcuts and optionally activate DevTools on each created `BrowserWindow`. | ||
* | ||
* @example | ||
* | ||
* import {app, BrowserWindow} from 'electron'; | ||
* import electronDebug from 'electron-debug'; | ||
* | ||
* electronDebug(); | ||
* | ||
* let win; | ||
* (async () => { | ||
* await app.whenReady(); | ||
* win = new BrowserWindow(); | ||
* }); | ||
*/ | ||
export default function electronDebug(options?: Readonly<Options>): void; | ||
|
||
/** | ||
* Reload the specified `BrowserWindow` instance or the focused one. | ||
* | ||
* @param [window] | ||
CvX marked this conversation as resolved.
Show resolved
Hide resolved
|
||
*/ | ||
export function refresh(window?: BrowserWindow = BrowserWindow.getFocusedWindow()): void; | ||
|
||
/** | ||
* Toggle DevTools for the specified `BrowserWindow` instance or the focused one. | ||
* | ||
* @param [window] | ||
*/ | ||
export function devTools(window?: BrowserWindow = BrowserWindow.getFocusedWindow()): void; | ||
|
||
/** | ||
* Open DevTools for the specified `BrowserWindow` instance or the focused one. | ||
* | ||
* @param [window] | ||
*/ | ||
export function openDevTools(window?: BrowserWindow = BrowserWindow.getFocusedWindow()): void; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import {expectType} from 'tsd-check'; | ||
import {BrowserWindow} from 'electron'; | ||
import electronDebug, {refresh, devTools, openDevTools} from '.'; | ||
|
||
expectType<void>(electronDebug({ | ||
enabled: true, | ||
showDevTools: true | ||
})); | ||
|
||
expectType<void>(refresh(new BrowserWindow())); | ||
expectType<void>(devTools()); | ||
expectType<void>(openDevTools()); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think we should use
readonly
on the specific properties whenever possible, asReadonly
will show up in the code completion and create noise:Maybe that's a non-issue. I dunno.
Thoughts?
*Really want the
readonly
type operators...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either…
Is that information useful in any way to the end user of the API? If it's not, then sure,
readonly
all the props. 😉There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s not. It’s only useful for us to ensure we don’t modify the object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s go with per-property annotation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. TS seems to be slowly closing in on that… 😅
microsoft/TypeScript#29435
microsoft/TypeScript#29510
Not quite there yet, but I like the trajectory. 😉