Build not passing - silent fail?

[kasperlewau]

I hate to be this guy (chill, it's 0.10.0...) but, you've got an .only that's reporting a non-passing build as passing on [email protected] & [email protected] with a clean npm i.

Builds on

• Travis (https://travis-ci.org/sindresorhus/conf/jobs/139352324#L653)
• AppVeyor (https://ci.appveyor.com/project/sindresorhus/conf/build/6/job/ccvy2qihrr40tqh8#L770)

---

I'd submit a PR, but my head is not where it's supposed to be right now and duty calls (laundry...). Just though I'd let you know. Cheers! 🔨

[sindresorhus]

Ugh. Thanks for reporting :) Luckily, I only had a couple of incorrect tests. Code was working perfectly.

.only is so dangerous! I actually have XO linter set up, which bundles the https://github.com/avajs/eslint-plugin-ava/blob/master/docs/rules/no-only-test.md rule, which should have caught this. @jfmengels Any idea why it didn't?

[jfmengels]

Hmm, no, sounds really odd. I'll try to look into it later, but it is odd indeed.

[jfmengels]

import {serial as test} from 'ava'; it's this part that we don't recognize. Do we want to handle this case or does that seem like a weird use of AVA? IMO, it kind of does :D, but we should probably try to handle it.

Didn't know you could destructure things like serial and that it was the same thing as test.serial. We actually don't even handle anything when AVA is not imported as test. Plenty of room for improvement here.

[sindresorhus]

@jfmengels I opened an issue: avajs/eslint-plugin-ava#121