Handle destructured import of a test modifier

[sindresorhus]

From sindresorhus/conf#2 (comment)

I think we should handle the following cases:

import {serial as test} from 'ava';

import {serial} from 'ava';

It's a useful pattern to make a test file with only serial tests.

---

IssueHunt Summary

alexzherdev has been rewarded.

Backers (Total: $80.00)

• issuehunt ($80.00)

Submitted pull Requests

• #232 Support named imports and destructured requires

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[jfmengels]

Are there any other methods that are aliases to test.XXX?
If I do

import {cb as test} from 'ava';
test(...);

is that equivalent to

import test from 'ava';
test.cb(...);

or is serial a special one?

[jamestalmage]

All methods can be destructured and will work as expected, all the following are valid:

{cb as test}
{serial as test}
{cb as test}

You could even try something like this for a mocha-like interface:

import {beforeEach, afterEach, cb as it} from 'ava';

beforeEach(t => {...});

it('does things', t => {...});

Most of our rules should try and support all of those. We can update the use-test rule to warn against any particular patterns we don't like.

[jfmengels]

An idea for an other time, but maybe we could have an option in use-test that forbids destructuring of test, if users want to stick to the explicit test.

[jfmengels]

By the way, this looks a lot like what I did in eslint-plugin-lodash-fp. Starting to think we could maybe make a separate "enhancer" for this using enhance-visitor. Just to do the import logic understanding as in the lodash-fp link, and then we'll have to update the rules to use that.

[jamestalmage]

Much of the static-analysis work is already complete in babel-plugin-ava-test-data, so it should just be a matter of porting for the eslint API.

[IssueHuntBot]

@IssueHunt has funded $80.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[issuehunt-oss]

@sindresorhus has rewarded $72.00 to @alexzherdev. See it on IssueHunt

• 💰 Total deposit: $80.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $8.00