fix: Type.Optional() set nullable: true
#118
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋 @sinclairzx81
Current Behavior
Currently, a
null
value oftype: "string"
in theajv
schema is serialized as a double-quoted empty string (""
)Expected Behavior
A
null
string should be serialized asnull
, and not""
.Solution
This PR adds
nullable: true
to the schema object that returnsType.Optional
.Might be a BREAKING CHANGE, I don't really know to be honest but, maybe we could add an option to
Type.Optional
to not add this behavior by default.References