[Warlock][Diabolist] Adds Flame of Xoroth to Guardians and a small change in effect order. #9827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes Flame of Xoroth buff Guardians??
Updating following suggestions from SimcMinMax Disc.
|
This was apparently hotfixed on Oct 1, 2024. See #9590 . Similar updates for Xalan's Cruelty and Xalan's Ferocity (both Hellcaller spells) should be included as well for completeness. |
Yeah, before that hotfix those effects had some very weird implementation ingame, effectively it didn't work for guardian pets while having some double dipping interactions with player damage. |
|
Replaced by #9844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at adding Flame of Xoroth damage modifier to Guardian Pets, additionally, i noticed the effect 4 is the one responsible to buffing primary pet, and effect 3 is for guardians.
I hope i have done this right...