Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Wrong calculation of "Anschluss" if connected edges are long and not straight #41

Open
Tracked by #330
, #296
...
antonykamp opened this issue Apr 13, 2023 · 0 comments
Open
Tracked by #330
, #296
...

Bug: Wrong calculation of "Anschluss" if connected edges are long and not straight #41

antonykamp opened this issue Apr 13, 2023 · 0 comments

Comments

@antonykamp
Copy link

If the connected edges on a switch are long and not straight, it's possible that the function calc_anschluss_of_all_nodes calculates the angles between the edges wrong.

Possible fix: Use the next geo- instead of the top node from the signal. It needs #40, therefore.
This was referenced Apr 13, 2023
Closed
Open
antonykamp added a commit to BP2022-AP1/yaramo that referenced this issue Apr 18, 2023
@antonykamp
fix: use neighbor for angle calculation
7a6def0 
fixes Bug: Wrong calculation of "Anschluss" if connected edges are long and not straight simulate-digital-rail#41
antonykamp added a commit to BP2022-AP1/yaramo that referenced this issue Apr 18, 2023
@antonykamp
fix: use neighbor for angle calculation
51f8a77 
fixes Bug: Wrong calculation of "Anschluss" if connected edges are long and not straight simulate-digital-rail#41
@lpirl lpirl mentioned this issue Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antonykamp