Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON TypeError with Deno v1.0 Release Candidate #26

Closed
jeanlescure opened this issue May 11, 2020 · 1 comment · Fixed by #27
Closed

JSON TypeError with Deno v1.0 Release Candidate #26

jeanlescure opened this issue May 11, 2020 · 1 comment · Fixed by #27
Assignees
@jeanlescure
Labels
bug
Milestone
Version 3

Comments

@jeanlescure
Copy link
Collaborator

In line with testing short_uuid against the release candidate for version 1.0 of Deno we found that JSON imports have been removed due to it being bad practice.

A fix should be issued to keep Deno support.
@jeanlescure jeanlescure added this to the Version 3 milestone May 11, 2020
@jeanlescure jeanlescure self-assigned this May 11, 2020
@jeanlescure
Copy link
Collaborator Author

Just for completeness sake, the error being outputted is:

error: Uncaught TypeError: Cannot resolve extension for "file://path/to/version.json" with mediaType "Json".

jeanlescure added a commit that referenced this issue May 11, 2020
@jeanlescure
rc2 refactors out version json import, fixes #26
e1bf1ca
@jeanlescure jeanlescure mentioned this issue May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanlescure jeanlescure

Labels
bug
Projects
None yet
Milestone
Version 3
Development

Successfully merging a pull request may close this issue.

Release v3.0.0 simplyhexagonal/short-unique-id
1 participant
@jeanlescure