Add support for TWINT params #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visini
commented
Apr 8, 2024
andyundso
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
I think this is okay for now.
Right now params is more or less identical to body, except in body we add autoSettle. This is a good filtering mechanism for now, people are not allowed to pass arbitrary parameters.
It would be cool if params felt more "ruby'ish" (kind of like auto_settle translates to autoSettle), but then we would have to adapt everything within the parameters we already support. which then again brings up the question if we shouldn't just pass params directly instead of creating this body hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support merchant-initiated payments for the payment method TWINT (
TWI), the alias needs to be passed in the request body asbody["TWI"]["alias"], as defined byTwintAuthorizeRequest. This PR adds support for that.