Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON::Transaction::MerchantAuthorize #53

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

visini
Copy link
Contributor

@visini visini commented Jan 6, 2024

Datatrans::JSON::Transaction::Authorize is actually not for the authorize operation but rather for the init operation.

With these changes MerchantAuthorize is introduced, adding support for authorize operation, and thereby support for authorizing transactions without user interaction; so-called merchant initiated payments.

Copy link
Contributor

@andyundso andyundso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datatrans::JSON::Transaction::Authorize is actually not for the authorize operation but rather for the init operation.

yeah this rather confusing ... I propose to rename Datatrans::JSON::Transaction::Authorize to Datatrans::JSON::Transaction::Initialize, but create an alias for it (for now).

Once we release the breaking change where the XML API is removed, we can also remove the class alias.

README.markdown Show resolved Hide resolved
require 'datatrans/json/transaction/response'

class Datatrans::JSON::Transaction
class MerchantAuthorize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datatrans::JSON::Transaction::Authorize is actually not for the authorize operation but rather for the init operation.

yeah this rather confusing ... I propose to rename Datatrans::JSON::Transaction::Authorize to Datatrans::JSON::Transaction::Initialize, but create an alias for it (for now).

Once we release the breaking change where the XML API is removed, we can alias this class to Authorize.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I know what you mean but I'm not sure in what order it would be best to rename / alias / deprecate... If you propose something, I can review it 🙏

@visini visini closed this Jan 11, 2024
@visini visini deleted the add-merchant-authorize branch January 11, 2024 08:34
@visini visini restored the add-merchant-authorize branch January 11, 2024 08:34
@visini visini reopened this Jan 11, 2024
@andyundso andyundso merged commit d225bce into simplificator:master Jan 11, 2024
36 checks passed
@visini visini deleted the add-merchant-authorize branch January 11, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants