Fix PHP 8 error: Function libxml_disable_entity_loader() is deprecated

[Slamdunk]

No description provided.

[Slamdunk]

See shivammathur/setup-php#450

[tvdijen]

This only bypasses the deprecated method on PHP 8+, but that's wrong.. We need to know what alternative replaces this call.

[Slamdunk]

We need to know what alternative replaces this call.

Nothing: https://www.php.net/manual/en/migration80.deprecated.php#migration80.deprecated.libxml

Same fix was applied in laminas-xml package: laminas/laminas-xml#3

[tvdijen]

Ok thanks very much! I'm surprised to see a PR in this (yet) unused repository :)

[Slamdunk]

I'm surprised to see a PR in this (yet) unused repository :)

I need to upgrade my production to PHP 8, and v4 of saml2 doesn't support it, so I'm on dev-master across all your libraries

[codecov]

Codecov Report

Merging #6 (5c57868) into master (1db4c4f) will increase coverage by 0.43%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master       #6      +/-   ##
============================================
+ Coverage     18.01%   18.44%   +0.43%     
- Complexity      121      123       +2     
============================================
  Files            10       10              
  Lines           372      374       +2     
============================================
+ Hits             67       69       +2     
  Misses          305      305              

[tvdijen]

Ah, well in this case I must warn you that saml2 master is really bleeding edge and work in progress!
Good to see we have a voluntary beta-tester though 🤣

[tvdijen]

I see no harm in adding php 8 to the supported versions for saml2 v4, so if that would help you, please let me know

[Slamdunk]

Ah, well in this case I must warn you that saml2 master is really bleeding edge and work in progress!

Easy to tame on projects with 100% Mutation testing score + max level on static analysis tools

[Slamdunk]

I see no harm in adding php 8 to the supported versions for saml2 v4, so if that would help you, please let me know

As a OSS maintainer myself, I would suggest you to support every actively supported PHP version until you release a new stable of your own.
In other words, saml2:v4 should indeed support PHP 8, since v5 isn't ready yet.