Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to use em units for min and max font #3

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

kevcenteno
Copy link

This allows for using 'ems' for minFont, maxFont, minimum, and maximum, via a useEm boolean. fontRatio and lineRatio is essentially untouched.

A dirty example of usage would be:

$('#em').flowtype({
    minimum: 31.25,
    maximum: 75,
    minFont: 0.75,
    maxFont: 2.5,
    useEm: true
});

@kevcenteno
Copy link
Author

Smelly. Refactoring as we speak.

@aficiomaquinas
Copy link

+1

@kevcenteno
Copy link
Author

@jhnwlsn do you think this is a good idea? Should I change anything?

@alvarotrigo
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants