Merge pull request #616 from yujinakayama/stop-handling-filter-string…

…-as-regexp Stop handling string filters as regexps
simplecov-ruby · Oct 21, 2017 · e1fc172 · e1fc172
2 parents ebc0bac + 52f982e
commit e1fc172
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/simplecov/filter.rb b/lib/simplecov/filter.rb
@@ -51,7 +51,7 @@ class StringFilter < SimpleCov::Filter
     # Returns true when the given source file's filename matches the
     # string configured when initializing this Filter with StringFilter.new('somestring)
     def matches?(source_file)
-      (source_file.project_filename =~ /#{filter_argument}/)
+      source_file.project_filename.include?(filter_argument)
     end
   end
 

diff --git a/spec/filters_spec.rb b/spec/filters_spec.rb
@@ -28,15 +28,15 @@
       expect(SimpleCov::StringFilter.new("sample.rb")).to be_matches subject
     end
 
+    it "doesn't match a new SimpleCov::StringFilter '.pl'" do
+      expect(SimpleCov::StringFilter.new(".pl")).not_to be_matches subject
+    end
+
     it "doesn't match a parent directory with a new SimpleCov::StringFilter" do
       parent_dir_name = File.basename(File.expand_path("..", File.dirname(__FILE__)))
       expect(SimpleCov::StringFilter.new(parent_dir_name)).not_to be_matches subject
     end
 
-    it "matches a new SimpleCov::StringFilter '/fixtures/'" do
-      expect(SimpleCov::StringFilter.new("sample.rb")).to be_matches subject
-    end
-
     it "matches a new SimpleCov::RegexFilter /\/fixtures\//" do
       expect(SimpleCov::RegexFilter.new(/\/fixtures\//)).to be_matches subject
     end