Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: function node children update #58

Merged
merged 1 commit into from
Nov 18, 2023
Merged

fix: function node children update #58

merged 1 commit into from
Nov 18, 2023

Conversation

JankoLancer
Copy link
Contributor

No description provided.

@Sese-Schneider
Copy link
Member

@JankoLancer thank you for your PR.
Could you please elaborate as why this change is required?

Could you provide us with an example of what this fixes?

@p-mazhnik
Copy link
Contributor

@Sese-Schneider
FunctionNode has only two children: functionName and argument. Therefore, updateChildren function will take the list of two elements as an argument, with indexes 0 and 1, so there will be an error when we try to get something with index 2. This PR fixes it.
You can take a look at FracNode for the similar updateChildren function that doesn't have this typo.

@Sese-Schneider Sese-Schneider merged commit 925787c into simpleclub:master Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JankoLancer @Sese-Schneider @p-mazhnik