Add foreign key support for sqlite #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitchoi
changed the title
|
WIP because its tests will break after #81 is merged. |
Current coverage is 79.64%@@ master #94 diff @@
==========================================
Files 27 27
Lines 906 958 +52
Methods 0 0
Messages 0 0
Branches 83 91 +8
==========================================
+ Hits 717 763 +46
- Misses 163 166 +3
- Partials 26 29 +3
|
kitchoi
changed the title
|
@sbo ready for review again |
| @@ -90,6 +93,14 @@ class Accounting(Base): | |||
| application_policy = relationship("ApplicationPolicy") | |||
|
|
|||
|
|
|||
| @event.listens_for(Engine, "connect") | |||
| def set_sqlite_pragma(dbapi_connection, connection_record): | |||
There was a problem hiding this comment.
import sqlite3 here.
There was a problem hiding this comment.
I would call it _enable_foreign_keys()
There was a problem hiding this comment.
I made the function name _set_sqlite_pragma so that sphinx would skip it. It is the place where future pragma can be added though so I kept the rest of the name
|
codecov irrelevant. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #56