Rename orm_user to account and document as opaque-type #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 79.13%@@ master #89 diff @@
==========================================
Files 27 27
Lines 907 906 -1
Methods 0 0
Messages 0 0
Branches 83 83
==========================================
- Hits 718 717 -1
Misses 163 163
Partials 26 26
|
| """ | ||
|
|
||
| @abstractmethod | ||
| def get_apps_for_user(self, user): | ||
| """ Return an iterable of ApplicationConfig for a given User | ||
| def get_apps_for_user(self, account): |
There was a problem hiding this comment.
At this point I wonder if we should use get_apps_for_account instead.
There was a problem hiding this comment.
In my previous branch I did that, but think it might be too trivial that it is not worth breaking the public API that is in a public release.
There was a problem hiding this comment.
I don't think that anyone expects API consistency before 1.0...
There was a problem hiding this comment.
I don't mind breaking it at all if we all agree to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #67