Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyterhub to 0.9.x series #604

Merged
merged 12 commits into from
May 30, 2022
Merged

Conversation

flongford
Copy link
Contributor

@flongford flongford commented May 29, 2022

Approaches #605

Upgrades the version of jupyterhub to latest in 0.9.x series (0.9.6).

@flongford
Copy link
Contributor Author

flongford commented May 30, 2022

Selenium tests likely failing on Ubuntu builds due to low bandwith on GitHub CI - they pass on my local Linux machine.

It looks like a click action is being blocked by a partially visible modal so we probably just need to robustify the tests by waiting until the modal has fully disappeared from the screen before performing the click.

As reference, something similar was carried out previously in this commit: 62efbfa

@codecov-commenter
Copy link

Codecov Report

Merging #604 (8134567) into master (9081860) will increase coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head 8134567 differs from pull request most recent head a13272f. Consider uploading reports for the commit a13272f to get more accurate results

@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files          93       93           
  Lines        4418     4420    +2     
  Branches      432      432           
=======================================
+ Hits         4188     4190    +2     
  Misses        168      168           
  Partials       62       62           
Impacted Files Coverage Δ
...ager/jupyterhub/auth/simphony_remote_auth_mixin.py 38.09% <0.00%> (ø)
remoteappmanager/jupyterhub/spawners.py 87.87% <ø> (ø)
...moteappmanager/handlers/tests/test_base_handler.py 100.00% <100.00%> (ø)
remoteappmanager/jupyterhub/tests/test_spawners.py 93.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9081860...a13272f. Read the comment docs.

@flongford flongford marked this pull request as ready for review May 30, 2022 10:50
@flongford flongford merged commit ada647d into master May 30, 2022
@flongford flongford deleted the maint/update-jupyterhub-0.9.x branch May 30, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants