Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTD build failures #600

Merged
merged 8 commits into from
Apr 14, 2022
Merged

Fix RTD build failures #600

merged 8 commits into from
Apr 14, 2022

Conversation

flongford
Copy link
Contributor

@flongford flongford commented Apr 14, 2022

Closes #599

Applies a minimal solution of pinning jinja2<3.1.0 when building on RTD and tidies up declaration of requirements between platforms.

In the long run we probably should be using later version of Sphinx on RTD, but this may require a larger number of changes.

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #600 (a773a9a) into master (15c24cb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          92       92           
  Lines        4305     4305           
  Branches      422      422           
=======================================
  Hits         4105     4105           
  Misses        140      140           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c24cb...a773a9a. Read the comment docs.

@flongford flongford marked this pull request as ready for review April 14, 2022 22:35
@flongford flongford merged commit 2f6e719 into master Apr 14, 2022
@flongford flongford deleted the fix/rtd-build-failures branch April 14, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTD builds failing due to jinja2 dependency issue
2 participants