Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version constraint to the docutils dependency #575

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

peterzahemszky
Copy link
Contributor

Add a version constraint to the docutils dependency to resolve problems with Sphinx.

Closes #574.

@codecov-commenter
Copy link

Codecov Report

Merging #575 (d82b2f5) into master (fc5f0ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #575   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          92       92           
  Lines        4305     4305           
  Branches      277      277           
=======================================
  Hits         4105     4105           
  Misses        140      140           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5f0ae...d82b2f5. Read the comment docs.

Copy link
Contributor

@flongford flongford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this @peterzahemszky - in order to catch any further regressions, could we include running make docs as part of our CI builds?

I think we only need to do so on one of the target OS (i.e. Ubuntu).

Scratch that - we already do it:

- name: Build docs
run: |
. venv/bin/activate
make docs

Copy link
Contributor

@flongford flongford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterzahemszky peterzahemszky merged commit 43943f4 into master Nov 19, 2021
@peterzahemszky peterzahemszky deleted the 574-docutils-version branch November 19, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make docs fails with docutils 0.18
3 participants