Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build matrix with CentOS to GH Actions #558

Merged
merged 9 commits into from
Aug 3, 2021
Merged

Conversation

robertopreste
Copy link
Contributor

@robertopreste robertopreste commented Jul 30, 2021

Closes #557

This PR adds a second workflow that targets CentOS 7, only installing Symphony Remote on this platform. Tests are run separately in the Ubuntu workflow.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #558 (ca2f30b) into master (4b07ecd) will not change coverage.
The diff coverage is n/a.

❗ Current head ca2f30b differs from pull request most recent head 6169a52. Consider uploading reports for the commit 6169a52 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          92       92           
  Lines        4168     4168           
  Branches      269      269           
=======================================
  Hits         3964     3964           
  Misses        144      144           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b07ecd...6169a52. Read the comment docs.

Copy link
Contributor

@flongford flongford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robertopreste! I only have a few minor comments, can re-review whenever

.github/workflows/build_test_ubuntu18.yml Outdated Show resolved Hide resolved
.github/workflows/build_centos7.yml Show resolved Hide resolved
.github/workflows/build_centos7.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@flongford flongford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flongford flongford merged commit ad9c61e into master Aug 3, 2021
@flongford flongford deleted the 556-centos-gh-actions branch August 3, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants