-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build matrix with CentOS to GH Actions #558
Conversation
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 95.10% 95.10%
=======================================
Files 92 92
Lines 4168 4168
Branches 269 269
=======================================
Hits 3964 3964
Misses 144 144
Partials 60 60 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @robertopreste! I only have a few minor comments, can re-review whenever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #557
This PR adds a second workflow that targets CentOS 7, only installing Symphony Remote on this platform. Tests are run separately in the Ubuntu workflow.