Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle all javascript and CSS #510

Merged
merged 9 commits into from
Jun 6, 2017
Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jun 6, 2017

  • Removes IE dependencies
  • Bundle Admin-lte and its dependencies in one javascript file (sharedDependencies.js) loaded both by the admin page and the user page.
  • Bundle Admin-lte and its dependencies in one CSS file (sharedDependencies.css) loaded both by the admin page and the user page.
  • Creates a new directory "dist/files" which contains all the files (fonts, images...) needed by the CSS.

It remains google analytics javascript, but it is loaded via https and depends on the backend.

Closes #484
Closes #485

@martinRenou martinRenou changed the title Bundle all javascript Bundle all javascript and CSS [WIP] Jun 6, 2017
@codecov-io
Copy link

codecov-io commented Jun 6, 2017

Codecov Report

Merging #510 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files          88       88           
  Lines        3960     3960           
  Branches      248      248           
=======================================
  Hits         3772     3772           
  Misses        137      137           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e623f7b...4ee5a32. Read the comment docs.

@martinRenou martinRenou changed the title Bundle all javascript and CSS [WIP] Bundle all javascript and CSS Jun 6, 2017
@stefanoborini stefanoborini merged commit 4293d79 into master Jun 6, 2017
@stefanoborini stefanoborini deleted the bundle-all-javascript branch June 6, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants