Fix issue when ApplicationView is not rendered because of an empty app list #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
changed the title
stefanoborini
previously requested changes
May 22, 2017
| let iframe = this.$el.querySelector('iframe'); | ||
| if(iframe !== null) { | ||
| iframe.focus(); | ||
| if(this.$el.querySelector !== undefined && // In case $el is not rendered |
There was a problem hiding this comment.
I think you are not using the right approach. if the element is not rendered, you should check if the element is not rendered. You are probing the existence of a routine that happens to be correlated to the existence of the element, but it's not the thing that is the core issue.
There was a problem hiding this comment.
You are absolutely right
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 88 88
Lines 4077 4077
Branches 259 259
=======================================
Hits 3887 3887
Misses 138 138
Partials 52 52Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #461