Change error dialogs #450
Change error dialogs #450
Conversation
martinRenou
commented
May 12, 2017
•
martinRenou
commented
- Remove old dialogs and use modal dialogs generated by Vue in ApplicationListView and ApplicationView (when start or stop fails).
- ConfirmDialog component now uses the adminlte classes instead of custom CSS classes.
- ConfirmDialog component now display a Cancel button only if an associated callback is defined.
Codecov Report
@@ Coverage Diff @@
## switch_to_vue #450 +/- ##
==============================================
Coverage 95.33% 95.33%
==============================================
Files 88 88
Lines 4077 4077
Branches 259 259
==============================================
Hits 3887 3887
Misses 138 138
Partials 52 52Continue to review full report at Codecov.
|
| @@ -175,17 +174,17 @@ define([ | |||
|
|
|||
| var url_id = appStopping.appData.container.url_id; | |||
|
|
|||
| resources.Container.delete(url_id) | |||
| return resources.Container.delete(url_id) | |||
| .done(function() { | |||
There was a problem hiding this comment.
you don't have to do a done. Let the calling client handle the failure.
| @@ -154,18 +153,18 @@ define([ | |||
| configurablesData[tag] = configurable.asConfigDict(); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
create a promise. if you hit any of the fail, you resolve the promise by reject. otherwise, you say success.
| mapping_id: currentApp.appData.mapping_id, | ||
| configurables: configurablesData | ||
| }).done(function() { | ||
| this.updateIdx(selectedIndex) | ||
| .fail(function(error) { | ||
| currentApp.status = Status.STOPPED; | ||
| dialogs.webapi_error_dialog(error); | ||
| return error; |
There was a problem hiding this comment.
you have to add a done here to resolve the promise
| '<section class="sidebar">' + | ||
| '<section class="sidebar">' + | ||
| ' <!-- Error dialog -->' + | ||
| ' <confirm-dialog v-if="showErrorDialog"' + |
There was a problem hiding this comment.
{
errorDialog: {
visible: true
}
}
| '<section class="sidebar">' + | ||
| ' <!-- Error dialog -->' + | ||
| ' <confirm-dialog v-if="showErrorDialog"' + | ||
| ' :title="getErrorTitle()"' + |
There was a problem hiding this comment.
you just need {"whatever string "+errorMessage}
| return { 'searchInput': '' }; | ||
| return { | ||
| 'searchInput': '', | ||
| showErrorDialog: false, |
There was a problem hiding this comment.
errorDialog: {
show: true,
message: ""
}
| var stoppingAppName = this.$options.filters.appName( | ||
| this.model.appList[index].appData.image); | ||
| this.model.stopApplication(index).fail(function(error) { | ||
| this.stoppingError = error; |
| this.showErrorDialog = true; | ||
| }.bind(this)); | ||
| }, | ||
| getErrorTitle: function() { |
| @@ -11,6 +12,16 @@ define([ | |||
| '<section id="appview"' + | |||
| ' v-if="currentApp !== null"' + | |||
| ' :class="{ content: true, \'no-padding\': currentApp.isRunning() }">' + | |||
| ' <!-- Error dialog -->' + | |||
| ' <confirm-dialog v-if="showErrorDialog"' + | |||
And send the startApplication event to GA only if the start was a success
