Backend resource support for admin interface #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
=========================================
+ Coverage 95.26% 95.3% +0.04%
=========================================
Files 96 92 -4
Lines 4114 4090 -24
Branches 254 257 +3
=========================================
- Hits 3919 3898 -21
+ Misses 143 141 -2
+ Partials 52 51 -1
Continue to review full report at Codecov.
|
martinRenou
requested changes
May 8, 2017
| @gen.coroutine | ||
| @authenticated | ||
| def items(self, items_response, **kwargs): | ||
| db = self.application.db |
There was a problem hiding this comment.
You can maybe add a docstring
| @gen.coroutine | ||
| @authenticated | ||
| def items(self, items_response, **kwargs): | ||
| users = self.application.db.list_users() |
martinRenou
approved these changes
May 8, 2017
stefanoborini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the server side admin webapi to support switch to Vue based interface.