Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping comments in whitelist file #364

Merged
merged 4 commits into from
Mar 9, 2017

Conversation

stefanoborini
Copy link
Contributor

Skipping lines starting with "#" in the whitelist file.

@codecov-io
Copy link

codecov-io commented Mar 9, 2017

Codecov Report

Merging #364 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   95.34%   95.35%   +0.01%     
==========================================
  Files          92       92              
  Lines        3929     3939      +10     
  Branches      254      254              
==========================================
+ Hits         3746     3756      +10     
  Misses        126      126              
  Partials       57       57
Impacted Files Coverage Δ
.../jupyterhub/auth/github_whitelist_authenticator.py 100% <ø> (ø)
.../auth/tests/test_github_whitelist_authenticator.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d92b947...1db1165. Read the comment docs.

@stefanoborini stefanoborini merged commit 7f99a84 into master Mar 9, 2017
@stefanoborini stefanoborini deleted the skip-comments-in-whiitelist branch March 9, 2017 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants