Fixes xForward dependency. #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current release of configurable-http-proxy has a bug that inverts the logic of x-forward addition. This ruins the functionality of anything reverseproxied, specifically the file transfer (which relies on these headers to produce the correct urls)
Current coverage is 93.22% (diff: 100%)@@ master #219 diff @@
==========================================
Files 73 73
Lines 3175 3175
Methods 0 0
Messages 0 0
Branches 209 209
==========================================
Hits 2960 2960
Misses 151 151
Partials 64 64
|
stefanoborini
deleted the
feature/fix-x-forward-proxy-dependency-0908-1131
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current release of configurable-http-proxy has a bug that inverts the logic
of x-forward addition. This ruins the functionality of anything reverseproxied,
specifically the file transfer (which relies on these headers to produce the correct
urls)