chore: fix utils/utils.go / repoDir #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atsushifx
commented
Dec 15, 2023
atsushifx
commented
- first, reference $XDG_CACHE_HOME directory to All OS's cache directory
- fix: change save directory gibo to gibo/gitignore-boilerplates
- fix: compare string change == to string.equalFold
- first, reference $XDG_CACHE_HOME directory to All OS's cache directory - fix: change save directory gibo to gibo/gitignore-boilerplates - fix: compare string change == to string.equalFold
simonwhitaker
requested changes
Dec 16, 2023
utils/utils.go
Outdated
| cacheDir, err := os.UserCacheDir() | ||
| if err != nil { | ||
| log.Fatalln("gibo can't determine your user cache directory. Please file an issue at https://github.com/simonwhitaker/gibo/issues") | ||
| xdgCacheDir := os.Getenv("XDG_CACHE_HOME") |
There was a problem hiding this comment.
What's your intention here? os.UserCacheDir() will respect XDG_CACHE_HOME on Unix systems. I suppose people on macOS or Windows might set the XDG_CACHE_HOME environment variable, but I don't think it makes sense to try to honour non-standard configs; the logic here would potentially get very complicated, for little benefit.
There was a problem hiding this comment.
I understood. New commit:13959a970eda9e4c61afe6105f176c01f9d14ff5 remove these codes relied XDG_CACHE_HOME.
please check them.
simonwhitaker
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.