Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for latest TableauScraping and protect against failures due to breaking changes in that library #4

Closed
brentajones opened this issue Mar 22, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@brentajones
Copy link

brentajones commented Mar 22, 2021

I have a Github Actions scraper using this that started erroring out earlier today. Digging into the code a little, I found this update to TableauScraping, which seems like it renamed dashboards to workbooks? I don't know enough about the code to know for sure.

My error log says:

AttributeError: 'TableauScraper' object has no attribute 'getDashboard'

@brentajones brentajones changed the title ts.getDashboard maybe renamed? ts.getDashboard maybe renamed in TableauScraping? Mar 22, 2021
@simonw simonw added the bug Something isn't working label Mar 22, 2021
@simonw
Copy link
Owner

simonw commented Mar 22, 2021

Thanks for reporting this - yes it looks like that TableauScraping library is still pretty unstable (it's pre-1.0). I'm going to upgrade this script, then pin a version and switch to using Dependabot to apply future upgrades.

@simonw
Copy link
Owner

simonw commented Mar 22, 2021

I've enabled Dependabot, so hopefully it will create a pull request bumping TableauScraper shortly... which should fail, because of this breaking change.

@simonw
Copy link
Owner

simonw commented Mar 22, 2021

... that worked, here's the Dependabot PR: #5

@simonw
Copy link
Owner

simonw commented Mar 22, 2021

... and the tests for that failed with:

>       assert result.exit_code == 0
E       assert 1 == 0
E        +  where 1 = <Result AttributeError("'TableauScraper' object has no attribute 'getDashboard'",)>.exit_code

@simonw simonw changed the title ts.getDashboard maybe renamed in TableauScraping? Update for latest TableauScraping and protect against failures due to breaking changes in that library Mar 22, 2021
@simonw simonw closed this as completed Mar 22, 2021
simonw added a commit that referenced this issue Mar 22, 2021
@simonw
Copy link
Owner

simonw commented Mar 22, 2021

OK, this should be fixed in the new release: https://github.com/simonw/tableau-to-sqlite/releases/tag/0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants