Use python-dateutil package instead of dateutils #324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on updating
sqlite-utils
for NixOS/Nixpkgs, I came a cross the following:In 5ec6686, a new dependency was added on
dateutils
(https://pypi.org/project/dateutils/).I believe this is unintentional, and instead
python-dateutil
(https://pypi.org/project/python-dateutil/) was intended.My reasoning is:
python-dateutil
is imported here in recipes.pymypy
type-python-dateutil
dependency in setup.pypython-dateutil
is a dependency ofdateutils
as seen in the output in docs/tutorial.ipynbSeems like the trailing "s" seems to be the source of confusion 😅
I've swapped the dependencies out, hope this helps.