Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote collections to a top-level command #229

Closed
simonw opened this issue Sep 5, 2023 · 2 comments
Closed

Promote collections to a top-level command #229

simonw opened this issue Sep 5, 2023 · 2 comments
Labels
design duplicate This issue or pull request already exists embeddings
Milestone

Comments

@simonw
Copy link
Owner

simonw commented Sep 5, 2023

Currently the CLI tools for managing collections are tucked away in llm embed-db:

llm embed-db --help
Usage: llm embed-db [OPTIONS] COMMAND [ARGS]...

  Manage the embeddings database

Options:
  --help  Show this message and exit.

Commands:
  collections        Output the path to the embeddings database
  delete-collection  Delete the specified collection
  path               Output the path to the embeddings database

I think collections deserve to be a top-level concern in the CLI tool, so you can do this:

# View collections
llm collections

# Delete a collection
llm collections delete my-collection

# View items in a collection
llm collections show my-collection

Not completely happy with that last command. Some options:

  • llm collections my-collection - uses up the namespace that I want to use for llm collections delete and suchlike
  • llm collections list my-collection - confusing since llm collections is presumably a default alias of llm collections list same as how llm aliases list and llm templates list and llm models list work.
@simonw simonw added duplicate This issue or pull request already exists design embeddings labels Sep 5, 2023
@simonw
Copy link
Owner Author

simonw commented Sep 5, 2023

I could drop llm embed-db entirely if I move this command to collections instead:

llm collections path

@simonw simonw added this to the 0.10 milestone Sep 10, 2023
@simonw
Copy link
Owner Author

simonw commented Sep 10, 2023

I'm going with llm collections show xxx for consistency with llm templates show xxx.

@simonw simonw closed this as completed Sep 10, 2023
simonw added a commit that referenced this issue Sep 12, 2023
simonw added a commit that referenced this issue Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design duplicate This issue or pull request already exists embeddings
Projects
None yet
Development

No branches or pull requests

1 participant