-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title, description, settings and custom template to dashboard queries #156
Open
drkane
wants to merge
22
commits into
simonw:main
Choose a base branch
from
drkane:dk/issue-141
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert formset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a number of new fields to the dashboard query object, to meet some of the needs described in issue #141.
The new fields are:
title
- a title for the query - by default this is displayed above itdescription
- markdown description of the query - displayed between the title and the query resultscreated_at
- date the query was created, to match the Dashboard object.template
- a space where the user can specify the template they want to use. This is searched for indjango_sql_dashboard/widgets/XXXX.html
in the same way as it is done when looking for a template based on a column name. This allows for greater flexibility than only using the column names to selectsettings
- a json field which is passed to the template and could be used to customise the display of the widget. The use-cases I envisage for this include being able to size your widgets into a masonry-type layout, and customising a chart design.At the moment the new fields are only editable through the admin interface, and they are all optional. So the default user experience for creating a dashboard is unaffected. The template name goes through django's standard template lookup so it should use the default template if it can't find the one specified.
NB this also removes support for Python 3.6 and Postgres 10 and 11 (due to those failing in github actions) and adds support for python 3.11 and postgres 14 and 15. It also fixes an error in the
test_html_widget
test where it was testing the markdown template instead of the html one.