Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New base64 upgrade redirect mode causes infinite redirect loop #67

Closed
simonw opened this issue Apr 14, 2021 · 0 comments
Closed

New base64 upgrade redirect mode causes infinite redirect loop #67

simonw opened this issue Apr 14, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Apr 14, 2021

I think because if there is no ?sql= at all you get redirected:

def check_for_base64_upgrade(queries):
# Strip of the timing bit if there is one
queries = [q.split(":")[0] for q in queries]
# If every query is base64-encoded JSON, return a new querystring
if not all(is_valid_base64_json(query) for query in queries):
return

@simonw simonw added the bug Something isn't working label Apr 14, 2021
@simonw simonw closed this as completed in 48e345d Apr 14, 2021
simonw added a commit that referenced this issue Apr 14, 2021
simonw added a commit to CAVaccineInventory/vial that referenced this issue Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant