Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private (or anything other than public) dashboards should not be cached #43

Closed
simonw opened this issue Mar 19, 2021 · 1 comment
Closed

Private (or anything other than public) dashboards should not be cached #43

simonw opened this issue Mar 19, 2021 · 1 comment
Labels
bug Something isn't working security

Comments

@simonw
Copy link
Owner

simonw commented Mar 19, 2021

I noticed that a private dashboard running behind Cloudflare (on my blog) got cached in the public Cloudflare cache when I loaded it as an authenticated user - and could then be seen by logged-out users. This is bad.
@simonw simonw added bug Something isn't working security labels Mar 19, 2021
@simonw
Copy link
Owner Author

simonw commented Mar 21, 2021

I'll add Cache-Control: private to any dashboard that isn't public on unlisted.

@simonw simonw closed this as completed in 2443960 Mar 21, 2021
simonw added a commit that referenced this issue Mar 21, 2021
@simonw
Release 0.4a1
69a3552 
Refs #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw