Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document permissions needed to edit a dashboard #132

Closed
toolness opened this issue Jun 15, 2021 · 0 comments
Closed

Document permissions needed to edit a dashboard #132

toolness opened this issue Jun 15, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@toolness
Copy link
Contributor

While I was investigating #130, I realized that there's something a bit confusing about this package, which is that editing them takes a user to the Django admin edit view for a Dashboard. This seems to imply that a user needs to at least have is_staff=True, since users who aren't staff can't access the Django admin at all (at least, I think they can't). It seems like this should be documented.

Beyond that, though, I'm confused by what kinds of permissions a user whom we want to allow editing of dashboards should have. Because they're being directed to a Django admin edit view, it feels like the user should be required to have "change" permission for Dashboard models, but they don't actually appear to need to... maybe this should be documented?

@simonw simonw added the documentation Improvements or additions to documentation label Jul 1, 2021
@simonw simonw closed this as completed in 6b07f7c Jul 1, 2021
simonw added a commit that referenced this issue Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants