Fixed markdown bug rendering null values, closes #124

simonw · Jun 3, 2021 · 119a102 · 119a102
1 parent 91a714e
commit 119a102
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/django_sql_dashboard/templatetags/django_sql_dashboard.py b/django_sql_dashboard/templatetags/django_sql_dashboard.py
@@ -55,6 +55,7 @@ def sql_dashboard_bleach(value):
 
 @register.filter
 def sql_dashboard_markdown(value):
+    value = value or ""
     return mark_safe(
         bleach.linkify(
             bleach.clean(

diff --git a/test_project/test_widgets.py b/test_project/test_widgets.py
@@ -140,14 +140,25 @@ def test_big_number_widget(admin_client, dashboard_db):
     ) in html
 
 
-def test_markdown_widget(admin_client, dashboard_db):
+@pytest.mark.parametrize(
+    "sql,expected",
+    (
+        (
+            "select '# Foo\n\n## Bar [link](/)' as markdown",
+            '<h1>Foo</h1>\n<h2>Bar <a href="/" rel="nofollow">link</a></h2>',
+        ),
+        ("select null as markdown", ""),
+    ),
+)
+def test_markdown_widget(admin_client, dashboard_db, sql, expected):
     response = admin_client.post(
         "/dashboard/",
-        {"sql": "select '# Foo\n\n## Bar [link](/)' as markdown"},
+        {"sql": sql},
         follow=True,
     )
+    assert response.status_code == 200
     html = response.content.decode("utf-8")
-    assert '<h1>Foo</h1>\n<h2>Bar <a href="/" rel="nofollow">link</a></h2>' in html
+    assert expected in html
 
 
 def test_html_widget(admin_client, dashboard_db):