Quick (and uninformed and perhaps misguided) attempt to add a <base> url for hosting datasette at a particular host/URI #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…url for hosting datasette at a particular host/URI
terrycojones
commented
Dec 18, 2019
| @@ -126,6 +126,11 @@ | |||
| False, | |||
| "Force URLs in API output to always use https:// protocol", | |||
| ), | |||
| ConfigOption( | |||
| "base_url", | |||
| "", | |||
There was a problem hiding this comment.
Maybe the default should be / to try to ensure that the behaviour with this change is in accordance with the way things were. Then the leading slashes that I dropped get put back in by the <base> tag in case you don't specify one in the config. The downside(?) is that your pages always have a base tag. I used to use <base> a lot back in 1995 or so, to host multiple domains/sites on one server, before the advent of the Host header, etc.
|
This has been replaced by #708, which is close to being ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, I don't really know what I'm doing... so this is just a suggested approach. I've not written tests, I've not run the tests, I don't know if I've missed some absolute URLs that would need to have the leading slash dropped.
BUT, I tested it with
--config base_url:http://127.0.0.1:8001/on the command line and from what little I know about datasette it's at least working in some obvious cases.My changes are based on what I saw in 8da2db4 (thanks!)
I'm happy to be more thorough on this if you think it's worth pursuing.
Fixes #394 (he said, optimistically).