Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial alter table support for the JSON API #2261

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Initial alter table support for the JSON API #2261

merged 7 commits into from
Feb 8, 2024

Conversation

simonw
Copy link
Owner

@simonw simonw commented Feb 8, 2024

Refs:

TODO:

  • Treat initial table creation as alter: true for /-/create with rows
  • Allow "alter": true for subsequent calls to /-/create if user has alter-table permission
  • Document the above
  • "alter": true support for /db/table/-/insert
  • "alter": true support for /db/table/-/upsert
  • "alter": true support for /db/table/rowid/-/update

📚 Documentation preview 📚: https://datasette--2261.org.readthedocs.build/en/2261/

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (569aacd) 92.81% compared to head (75362fc) 92.56%.

❗ Current head 75362fc differs from pull request most recent head fd9dce0. Consider uploading reports for the commit fd9dce0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2261      +/-   ##
==========================================
- Coverage   92.81%   92.56%   -0.26%     
==========================================
  Files          41       42       +1     
  Lines        6266     6331      +65     
==========================================
+ Hits         5816     5860      +44     
- Misses        450      471      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonw simonw marked this pull request as ready for review February 8, 2024 21:34
@simonw simonw merged commit c62cfa6 into main Feb 8, 2024
17 checks passed
@simonw simonw deleted the api-alter branch February 8, 2024 21:36
@simonw simonw added this to the Datasette 1.0a9 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant