table_config instead of table_metadata

[simonw]

Refs:

• Table configuration settings should work in both metadata.yml and datasette.yml #2247

---

📚 Documentation preview 📚: https://datasette--2257.org.readthedocs.build/en/2257/

[simonw]

Two failing tests (locally):

FAILED tests/test_api.py::test_database_page - AssertionError: assert equals failed
FAILED tests/test_facets.py::test_conflicting_facet_names_json - AssertionError: assert equals failed

The test_database_page problem boils down to this:

It's a hidden: False v.s. hidden: True thing.

The other one seems to be intermittent? I'll fix it after this first one

[simonw]

Yeah no_primary_key should be hidden=True - according to this:

datasette/tests/fixtures.py

Line 377 in 52a1dac

"no_primary_key": {"sortable_columns": [], "hidden": True},

Which is part of METADATA= in fixtures.py.

Note that this has moved to config - but I have new code that copies that value over from metadata so it should continue to work.

[simonw]

Running that failing test on its own passes:

just test -k test_conflicting_facet_names_json
==== test session starts ====
platform darwin -- Python 3.10.13, pytest-7.2.1, pluggy-1.0.0
SQLite: 3.44.0
rootdir: /Users/simon/Dropbox/Development/datasette, configfile: pytest.ini
plugins: icdiff-0.6, asyncio-0.20.3, xdist-3.1.0, timeout-2.1.0, anyio-3.6.2
asyncio: mode=strict
collected 1434 items / 1433 deselected / 1 selected                                                                                                      

tests/test_facets.py .                                                                                                                             [100%]
==== 1 passed, 1433 deselected in 1.20s ====

[simonw]

Now I get these two failures locally:

================================================================ short test summary info =================================================================
FAILED tests/test_facets.py::test_conflicting_facet_names_json - AssertionError: assert equals failed
FAILED tests/test_table_api.py::test_paginate_tables_and_views[/fixtures/paginated_view.json-201-9] - assert 9 == 5
============================================ 2 failed, 1429 passed, 2 skipped, 1 xfailed in 70.64s (0:01:10) =============================================

[simonw]

This seems bad: specifying those tests individually causes them to pass.

I'm worried I've got some state leaking between tests somehow.

[simonw]

I bet it's because move_table_config(metadata, config) modifies those dictionaries in-place.

[simonw]

I'm a bit worried about the performance overhead of this - not on Datasette itself (it only starts up once) but on the Datasette test suite which might call this hundreds of times.

[simonw]

I'm going to ignore this problem in the interest of getting this release done.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (52a1dac) 92.46% compared to head (b239ac6) 92.53%.

Files	Patch %	Lines
datasette/utils/__init__.py	96.29%	1 Missing ⚠️
datasette/views/table.py	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
+ Coverage   92.46%   92.53%   +0.07%     
==========================================
  Files          42       42              
  Lines        6290     6310      +20     
==========================================
+ Hits         5816     5839      +23     
+ Misses        474      471       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.