Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try test suite against macOS and Windows #1626

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

simonw
Copy link
Owner

@simonw simonw commented Feb 2, 2022

Refs #1625

@simonw simonw added the ci label Feb 2, 2022
@simonw
Copy link
Owner Author

simonw commented Feb 2, 2022

That broke on a macOS test: https://github.com/simonw/datasette/runs/5044036993?check_suite_focus=true

I'm going to remove macOS and Ubuntu and just try Windows purely to see what happens there.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1626 (4b4d0e1) into main (b5e6b1a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1626   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          34       34           
  Lines        4531     4531           
=======================================
  Hits         4176     4176           
  Misses        355      355           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e6b1a...4b4d0e1. Read the comment docs.

@simonw
Copy link
Owner Author

simonw commented Feb 3, 2022

OK, the tests do NOT pass against Windows! https://github.com/simonw/datasette/runs/5044105941

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant